sshnet Source Code Rss Feed

Patch Uploaded: #14339

pmilin — Fri, 19 Apr 2013 17:07:08 GMT

pmilin has uploaded a patch.

Description:
I was looking at the code for the local port forward and see that a TCPListener is being used with the address and port that is passed in. If the TCPListener is given port 0, it will find the first available. I am currently using this method to find the first available port in my code.

The trouble is that trying to find the first availabale port outside of the port forward class results in a race condition (the port could be taken in the time between when it is discovered as free and when the port forward class creates the listener on that port).

I was thinking it would be nice to have the BoundPort property on the ForwardedPortLocal class be used to get the port from the IPEndPoint that is created when Start() is called on the ForwardedPortClass. I can then use the resulting port when creating a socket connection, which is what I am doing in my code.

The code for getting the port from the listener is simply: BoundPort = ((IPEndPoint) listener.LocalEndpoint).Port

In cases where the port passed in is not zero, then the endpoint port should be the same as what was passed in. If the port passed in is zero, then BoundPort will return the actual port that is being used.

To go a step further, I created a new constructor that doesn't take a port parameter at all for the boundPort. In this case zero is the default.

The patch file in the attached zip shows the changes to the ForwardedPortLocal classes.

Source code checked in, #25006

olegkap — Sat, 06 Apr 2013 17:41:50 GMT

Update version number

Source code checked in, #24900

olegkap — Thu, 04 Apr 2013 15:33:47 GMT

Improve thread-safe event handling Replace Task.Factory.StartNew with ThreadPool.QueueUserWorkItem

Source code checked in, #24719

olegkap — Tue, 02 Apr 2013 00:48:38 GMT

Fix SshAuthenticationException by handling PartialSuccess response and continue authentication proccess in that case

Source code checked in, #24446

olegkap — Wed, 27 Mar 2013 17:34:59 GMT

Fix thread synchronization issue when uploading files using SCP

Source code checked in, #23481

olegkap — Thu, 07 Mar 2013 21:35:37 GMT

Fix and remove orphan threads when using port forwarding.

Source code checked in, #23469

olegkap — Thu, 07 Mar 2013 16:40:29 GMT

Replace previouse fix with Connection test vs if disposed

Source code checked in, #23468

olegkap — Thu, 07 Mar 2013 16:36:50 GMT

Dont call Channel Close() during dispose phase

Source code checked in, #23466

olegkap — Thu, 07 Mar 2013 16:14:36 GMT

Fix differnt SCP Upload issue. Remove not SCP feature of creating directory structure for uploaded files or directories

Source code checked in, #23337

olegkap — Sat, 02 Mar 2013 14:37:53 GMT

Lock _incoming object where performing Enqueue Rollback previouse commit

Source code checked in, #23336

olegkap — Sat, 02 Mar 2013 14:29:40 GMT

Lock _encoding in ShellStream when GetString operation is performed

Patch Applied: #13964

olegkap — Sat, 02 Mar 2013 13:58:20 GMT

olegkap has applied patch #13964.

Comment:
Applied in 23335 commit

Source code checked in, #23335

olegkap — Sat, 02 Mar 2013 13:57:32 GMT

Improve HTTP proxy error handling, regarding issue #1509 Apply 13964 patch to improve handling of multiple authentication methods

Patch Uploaded: #13964

StrAbZ — Fri, 01 Mar 2013 15:49:02 GMT

StrAbZ has uploaded a patch.

Description:
I found that in the Authenticate methods in the ConnectionInfo class, we got kicked out of the while whenever an authentication failed, without trying the others.

So I changed it a bit, it breaks only when the auth fails, and all the allowed auth have been tried. It will also, as usual, exit on success (the while condition) and when no method is provided that match the allowed authentication methods.

Source code checked in, #22965

olegkap — Thu, 07 Feb 2013 20:00:07 GMT

Commiting files that were not commited on previous commit

Source code checked in, #22964

olegkap — Thu, 07 Feb 2013 19:47:47 GMT

Improve internal server window size managment Fix exception handeling when multiple threads share one channel that can caus application hanging Improve cipher perfomance Other fixes

Source code checked in, #22899

olegkap — Sat, 02 Feb 2013 22:39:46 GMT

Improve SftpClient Exists method

Source code checked in, #22898

olegkap — Sat, 02 Feb 2013 21:16:30 GMT

Fix problem when huge files could be cut off in the middle

Source code checked in, #22896

olegkap — Sat, 02 Feb 2013 15:41:52 GMT

Fix SCP to handle root path

Source code checked in, #22833

olegkap — Thu, 31 Jan 2013 04:45:14 GMT

Add IPAddress as parameter to ForwardedPortRemote Allow all projects to generate xml documentation files Add GetIPAddress method and other minor refactoring