Possible memory leaks in HMac<T>

Feb 10, 2012 at 3:35 PM
Edited Feb 10, 2012 at 3:35 PM

System.Security.Cryptography.HashAlgorithm has a Dispose (or equivalent Clear) method which is documented as freeing both native and managed resources.  Most uses of this call Dispose() for the .NET 4.0 code but Renci.SshNet.Security.Cryptography.HMac<T> doesn't.  Should this class have a Dispose() method (which'd be used by all its clients)?

If you think this'd be a worthwhile change, I'm happy to propose diffs for it.

Coordinator
Feb 10, 2012 at 3:57 PM

Hi,

Yo probably right.

Can you please open an issue for this one so I dont forget to get back to it since I busy right now?

 

Thanks,

Oleg